feat : Review Service 빌더패턴 적용 마이페이지 분리 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youcastle03
reviewed
Oct 28, 2024
Comment on lines
+139
to
+140
| Long userId = userRepository.findByKakaoId(kakaoId) | ||
| .orElseThrow(() -> new IllegalArgumentException("사용자를 찾을 수 없습니다.")); |
There was a problem hiding this comment.
IllegalArgumentException보다는 만들어둔 UserNotFoundException은 어떨까요?
There was a problem hiding this comment.
해당 부분 코드는 jwt 토큰이 userId를 반환하게 수정되면 사라질 부분이어서 토큰 부분 수정 후에도 필요하다면 수정해보도록 하겠습니다!
youcastle03
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
=> 현재는 jwt 토큰에서 파싱된 String 타입의 kakaoId를 사용하고 있으나, 추후에 이를 기반으로 userId를 반환하게 수정할 예정입니다. 수정이 완료되면 kakaoId를 사용하는 부분도 그에 맞게 수정 할 예정입니다. 해당 내용은 userId가 필요한 메서드에 @todo 로 적어놓았습니다.