Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotFix: 속성 Value를 항상 null로 받는 문제 해결 #192

Merged
merged 2 commits into from
Nov 8, 2024
Merged

HotFix: 속성 Value를 항상 null로 받는 문제 해결 #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e195a9
fix: 속성 Value를 항상 null로 받는 문제 해결
GitJIHO Nov 8, 2024
5c9d8a9
deploy: 환경변수 추가
GitJIHO Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/testcode.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,7 @@ jobs:
SPRING_DATASOURCE_PASSWORD: ${{ secrets.MYSQL_PASSWORD }}
SPRING_JPA_HIBERNATE_DDL_AUTO: "update"
JWT_SECRET: ${{ secrets.JWT_SECRET }}
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
SLACK_CHARGE_REQUEST_URL: ${{ secrets.SLACK_CHARGE_REQUEST_URL }}
SLACK_WITHDRAW_REQUEST_URL: ${{ secrets.SLACK_WITHDRAW_REQUEST_URL }}
run: ./gradlew test
6 changes: 3 additions & 3 deletions src/main/java/com/example/sinitto/common/service/SlackMessageService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@
@Service
public class SlackMessageService {

@Value("${slack.webhook.url:#{null}}}")
@Value("${slack.webhook.url}")
private String slackWebhookUrl;

@Value("${slack.charge.request.url:#{null}}}")
@Value("${slack.charge.request.url}")
private String chargeRequestUrl;

@Value("${slack.withdraw.request.url:#{null}}}")
@Value("${slack.withdraw.request.url}")
private String withdrawRequestUrl;

private final RestTemplate restTemplate;
Expand Down
9 changes: 9 additions & 0 deletions src/test/java/com/example/sinitto/SinittoApplicationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,15 @@ class SinittoApplicationTests {
@Value("${jwt.secret}")
private String jwtSecret;

@Value("${slack.webhook.url}")
private String slackWebhookUrl;

@Value("${slack.charge.request.url}")
private String chargeRequestUrl;

@Value("${slack.withdraw.request.url}")
private String withdrawRequestUrl;

@Test
void contextLoads() {
assertNotNull(jwtSecret);
Expand Down