Refactor : ArgumentResolver -> Interceptor로 변경 #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
zzoe2346
approved these changes
Nov 8, 2024
| guardService.deleteGuard(memberId); | ||
| return ResponseEntity.ok("보호자가 삭제되었습니다."); | ||
| } | ||
|
|
||
| @Operation(summary = "모든 보호자 조회", description = "관리자용 API입니다.") | ||
| @GetMapping("/all") | ||
| public ResponseEntity<List<GuardResponse>> getAllGuards(@MemberId Long memberId) { | ||
| public ResponseEntity<List<GuardResponse>> getAllGuards(@RequestAttribute("memberId") Long memberId) { |
There was a problem hiding this comment.
이 메서드에서는 memberId 가 안쓰이는데 필요한 이유가 있을까요? HelloCallController 에도 3개정도 안쓰이는 memberId가있는데 사용 안하면 제거하는게 깔끔하지 않나 하는 생각입니다!
There was a problem hiding this comment.
관리자용은 나중에 따로 보안을 적용해서 제거하는게 옳다고 생각하지만, HelloCallController에 있는 memberId의 경우 제거했을 때 회원이 아니어도 조회가 가능하다고 생각되어 일단 남겨두겠습니다!
zzoe2346
reviewed
Nov 8, 2024
Comment on lines
73
to
83
| @Override | ||
| public void addInterceptors(InterceptorRegistry registry) { | ||
| registry.addInterceptor(jwtInterceptor).addPathPatterns("/api/**") | ||
| .excludePathPatterns("/api/auth/**") | ||
| .excludePathPatterns("/api/reviews") | ||
| .excludePathPatterns("/api/members/sinitto") | ||
| .excludePathPatterns("/api/members/guard") | ||
| .excludePathPatterns("/api/reviews/all") | ||
| .excludePathPatterns("/api/callbacks/twilio") | ||
| .excludePathPatterns("/api/hellocalls/admin/reports"); | ||
| } |
There was a problem hiding this comment.
콜백, 포인트 관련해서는 이상없이 잘 제외해주신거 같습니다!
zzoe2346
reviewed
Nov 8, 2024
Comment on lines
20
to
41
| @Override | ||
| public boolean preHandle(HttpServletRequest request, HttpServletResponse response, Object handler){ | ||
| String authorizationHeader = request.getHeader("Authorization"); | ||
| if (authorizationHeader == null || !authorizationHeader.startsWith("Bearer ")) { | ||
| throw new UnauthorizedException("토큰이 없거나, 헤더 형식에 맞지 않습니다."); | ||
| } | ||
| if (handler instanceof HandlerMethod) { | ||
| HandlerMethod handlerMethod = (HandlerMethod) handler; | ||
| Method method = handlerMethod.getMethod(); | ||
|
|
||
| Class<?>[] parameterTypes = method.getParameterTypes(); | ||
|
|
||
| String token = authorizationHeader.substring(7); | ||
| for (Class<?> paramType : parameterTypes) { | ||
| if (paramType.equals(Long.class)) { | ||
| String authorizationHeader = request.getHeader("Authorization"); | ||
| if (authorizationHeader == null || !authorizationHeader.startsWith("Bearer ")) { | ||
| throw new UnauthorizedException("토큰이 없거나, 헤더 형식에 맞지 않습니다."); | ||
| } | ||
|
|
||
| request.setAttribute("memberId", memberTokenService.getMemberIdByToken(token)); | ||
| String token = authorizationHeader.substring(7); | ||
|
|
||
| request.setAttribute("memberId", memberTokenService.getMemberIdByToken(token)); | ||
| return true; | ||
| } | ||
| } | ||
| } |
eunsoni
approved these changes
Nov 8, 2024
Comment on lines
+29
to
+33
| if (paramType.equals(Long.class)) { | ||
| String authorizationHeader = request.getHeader("Authorization"); | ||
| if (authorizationHeader == null || !authorizationHeader.startsWith("Bearer ")) { | ||
| throw new UnauthorizedException("토큰이 없거나, 헤더 형식에 맞지 않습니다."); | ||
| } |
GitJIHO
approved these changes
Nov 8, 2024
Comment on lines
+26
to
+29
| Class<?>[] parameterTypes = method.getParameterTypes(); | ||
|
|
||
| for (Class<?> paramType : parameterTypes) { | ||
| if (paramType.equals(Long.class)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
스크린샷 (선택)
💬 리뷰 요구사항(선택)
⏰ 현재 버그
✏ Git Close