Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: 최소 출금 포인트 설정, 첫 가입시 무료 포인트 적립 #205

Merged
merged 9 commits into from
Nov 9, 2024

Conversation

zzoe2346
Copy link
Contributor

@zzoe2346 zzoe2346 commented Nov 8, 2024

#️⃣ 연관된 이슈

ex) #이슈번호, #이슈번호

📝 작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요.(이미지 첨부 가능)

  • 최소 출금 포인트 설정
  • 첫 가입시 무료 포인트 적립
  • PointLog 엔티티 속성에서 content 가 String이었는데 이걸 enum인 Content로 변경
    • 코드리뷰반영

스크린샷 (선택)

💬 리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

회원가입 포인트 10000 포인트 했는데 너무 많은가요?

⏰ 현재 버그

✏ Git Close

close #이슈번호

close #194
close #195

@@ -25,24 +25,26 @@
@Service
public class MemberService implements MemberIdProvider {

private static final int WELCOME_POINT = 10000;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

회원가입시 포인트 10000원으로 했는데 너무 많으려나요?!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수수료가 20프로니까 ㅎㅎ

@zzoe2346 zzoe2346 self-assigned this Nov 8, 2024
@zzoe2346 zzoe2346 added the ✨ Feature 새로운 기능 추가 및 구현하는 경우 label Nov 8, 2024
@zzoe2346 zzoe2346 requested review from eunsoni, GitJIHO and 2iedo November 8, 2024 13:31
@zzoe2346 zzoe2346 changed the title Feat: 최소 출금 포인트 설정, 첫 가입시 무료 포인트 적립 Feat: 최소 출금 포인트 설정, 첫 가입시 무료 포인트 적립(수정중) Nov 8, 2024
@zzoe2346 zzoe2346 changed the title Feat: 최소 출금 포인트 설정, 첫 가입시 무료 포인트 적립(수정중) Feat: 최소 출금 포인트 설정, 첫 가입시 무료 포인트 적립 Nov 8, 2024
Copy link
Member

@GitJIHO GitJIHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 👍

@@ -25,24 +25,26 @@
@Service
public class MemberService implements MemberIdProvider {

private static final int WELCOME_POINT = 10000;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수수료가 20프로니까 ㅎㅎ

@@ -6,7 +6,7 @@

public record PointLogResponse(
LocalDateTime postTime,
String content,
PointLog.Content content,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@2iedo 2iedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~~

Copy link
Collaborator

@eunsoni eunsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다:>

@zzoe2346 zzoe2346 merged commit d0c6e35 into Weekly Nov 9, 2024
1 check passed
@zzoe2346 zzoe2346 deleted the Feat/issue-#193,#194,#195 branch November 9, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 새로운 기능 추가 및 구현하는 경우
Projects
None yet
4 participants