Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: 6차 코드리뷰 반영 #219

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Refactor: 6차 코드리뷰 반영 #219

merged 1 commit into from
Nov 12, 2024

Conversation

GitJIHO
Copy link
Member

@GitJIHO GitJIHO commented Nov 11, 2024

#️⃣ 연관된 이슈

📝 작업 내용

  • 메서드명 변경 (멘토님 추천)

💬 리뷰 요구사항(선택)

멘토님의 코멘트가

  • 깃액션 포트 환경변수화
  • deploy 결과 슬랙알림
  • 메서드명 변경
    였는데,
  1. 깃액션 포트가 현재 testcode.yml의 services : ports에 쓰여있는데, 이 부분은 환경변수화 할 수 없다고 합니다. 적용 x
  2. deploy의 gitaction결과를 슬랙 메시지로 보내느것을 추천하셨는데, deploy로직에서 호출하는 ssh내부의 deploy.sh에서 결과를 슬랙메시지로 전송하기 때문에 적용하지 않았습니다
    image
  3. 메서드명 변경 완료했습니다

⏰ 현재 버그

없습니다

✏ Git Close

close #218

@GitJIHO GitJIHO added the ♻️ Refactoring 코드 리팩토링 & 클린 코드 작업을 진행하는 경우 label Nov 11, 2024
@GitJIHO GitJIHO self-assigned this Nov 11, 2024
@GitJIHO GitJIHO linked an issue Nov 11, 2024 that may be closed by this pull request
Refactor: 6차 코드리뷰 반영 #218
Closed
3 tasks
zzoe2346
zzoe2346 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@zzoe2346 zzoe2346 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메서드명 변경 좋아요 👍

eunsoni
eunsoni approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@eunsoni eunsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!

2iedo
2iedo approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@2iedo 2iedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요!

@GitJIHO GitJIHO merged commit cfdd709 into Weekly Nov 12, 2024
1 check passed
@GitJIHO GitJIHO deleted the Refactor/issue-#218 branch November 13, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2iedo 2iedo 2iedo approved these changes

@eunsoni eunsoni eunsoni approved these changes

@zzoe2346 zzoe2346 zzoe2346 approved these changes

Assignees

@GitJIHO GitJIHO

Labels
♻️ Refactoring 코드 리팩토링 & 클린 코드 작업을 진행하는 경우
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: 6차 코드리뷰 반영
4 participants
@GitJIHO @zzoe2346 @eunsoni @2iedo