Skip to content
This repository was archived by the owner on Oct 16, 2023. It is now read-only.

Refactor CosineSimiliarity #111

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Refactor CosineSimiliarity #111

merged 1 commit into from
Sep 8, 2023

Conversation

mejai1206
Copy link
Contributor

🙏 Describe the pull request

CosineSimiliarity를 리팩토링했습니다.

✅ Checklist

  • Code follows the project's coding conventions and style.
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated, if necessary.

@mejai1206 mejai1206 requested a review from daemyung as a code owner September 7, 2023 10:06
@mejai1206 mejai1206 self-assigned this Sep 7, 2023
@mejai1206 mejai1206 force-pushed the refactor_consine_similiarity branch from 6edccda to e5a67bb Compare September 7, 2023 10:08
daemyung
daemyung suggested changes Sep 7, 2023
View reviewed changes
@mejai1206 mejai1206 force-pushed the refactor_consine_similiarity branch from e5a67bb to 6dda786 Compare September 8, 2023 01:49
@mejai1206 mejai1206 requested a review from daemyung September 8, 2023 01:50
kakao-steve-ai
kakao-steve-ai approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@kakao-steve-ai kakao-steve-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

daemyung
daemyung suggested changes Sep 8, 2023
View reviewed changes
@mejai1206 mejai1206 force-pushed the refactor_consine_similiarity branch from 6dda786 to 8bafc2d Compare September 8, 2023 04:35
@mejai1206 mejai1206 requested a review from daemyung September 8, 2023 04:38
daemyung
daemyung suggested changes Sep 8, 2023
View reviewed changes
@mejai1206 mejai1206 force-pushed the refactor_consine_similiarity branch from 8bafc2d to a3e17da Compare September 8, 2023 05:22
@mejai1206 mejai1206 requested a review from daemyung September 8, 2023 05:25
@mejai1206 mejai1206 force-pushed the refactor_consine_similiarity branch 2 times, most recently from 70944c5 to 33384e6 Compare September 8, 2023 06:21
daemyung
daemyung suggested changes Sep 8, 2023
View reviewed changes
daemyung
daemyung reviewed Sep 8, 2023
View reviewed changes
@mejai1206 mejai1206 force-pushed the refactor_consine_similiarity branch from 33384e6 to 119be97 Compare September 8, 2023 06:24
@mejai1206 mejai1206 force-pushed the refactor_consine_similiarity branch from 119be97 to 275375b Compare September 8, 2023 06:26
daemyung
daemyung approved these changes Sep 8, 2023
View reviewed changes
Copy link

@daemyung daemyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daemyung daemyung added the enhancement New feature or request label Sep 8, 2023
@daemyung daemyung merged commit 4c85456 into main Sep 8, 2023
@daemyung daemyung deleted the refactor_consine_similiarity branch September 8, 2023 07:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daemyung daemyung daemyung approved these changes

@kakao-steve-ai kakao-steve-ai kakao-steve-ai approved these changes

Assignees

@mejai1206 mejai1206

Labels
enhancement New feature or request
Projects
Trident
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mejai1206 @daemyung @kakao-steve-ai