Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Don't save unused tensors in Linear backward #137

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Don't save unused tensors in Linear backward #137

merged 1 commit into from
Sep 19, 2023

Conversation

mejai1206
Copy link
Contributor

πŸ™ Describe the pull request

λ―Έμ‚¬μš© ν…μ„œλ₯Ό μ €μž₯ν•˜λŠ” 뢀뢄을 μ‚­μ œν•˜μ˜€μŠ΅λ‹ˆλ‹€.

βœ… Checklist

  • Code follows the project's coding conventions and style.
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated, if necessary.

@mejai1206 mejai1206 requested a review from daemyung as a code owner September 19, 2023 23:01
@mejai1206 mejai1206 changed the title Remove not using tensor for backward Remove not using tensor for backward in Linear Sep 19, 2023
daemyung
daemyung suggested changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@daemyung daemyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Don't save unused tensors in Linear backward"둜 컀밋 메세지 λ³€κ²½ν•΄μ£Όμ‹œκ² μ–΄μš”? 이 λ¬Έμž₯이 λ³€κ²½ 사항을 더 잘 ν‘œν˜„ν•˜λŠ” 것 κ°™μŠ΅λ‹ˆλ‹€.

@mejai1206 mejai1206 changed the title Remove not using tensor for backward in Linear Don't save unused tensors in Linear backward Sep 19, 2023
@mejai1206 mejai1206 force-pushed the linear_save_tensor_fix branch from 86d3cfd to f3cfaa3 Compare September 19, 2023 23:14
@mejai1206
Copy link
Contributor Author

"Don't save unused tensors in Linear backward"
둜 컀밋메세지/PRλͺ… μˆ˜μ •ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

daemyung
daemyung approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@daemyung daemyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daemyung daemyung merged commit ab06b49 into main Sep 19, 2023
1 check passed
@daemyung daemyung deleted the linear_save_tensor_fix branch September 19, 2023 23:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daemyung daemyung daemyung approved these changes

@kakao-steve-ai kakao-steve-ai Awaiting requested review from kakao-steve-ai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mejai1206 @daemyung