Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Optimize CosineSimiliarity #141

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Optimize CosineSimiliarity #141

merged 1 commit into from
Sep 20, 2023

Conversation

mejai1206
Copy link
Contributor

🙏 Describe the pull request

CosineSimiliarity를 최적화하였습니다.
Linear의 가독성을 개선했습니다.

💬 Additional context

CosineSimiliarity

After
image

Before
image

✅ Checklist

  • Code follows the project's coding conventions and style.
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated, if necessary.

@mejai1206 mejai1206 requested a review from daemyung as a code owner September 20, 2023 08:53
kakao-steve-ai
kakao-steve-ai approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@kakao-steve-ai kakao-steve-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

daemyung
daemyung approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@daemyung daemyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daemyung daemyung merged commit c4d102a into main Sep 20, 2023
1 check passed
@daemyung daemyung deleted the optimize_cosine_similarity branch September 20, 2023 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kakao-steve-ai kakao-steve-ai kakao-steve-ai approved these changes

@daemyung daemyung daemyung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mejai1206 @daemyung @kakao-steve-ai