Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Optimize RMSNorm #142

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Optimize RMSNorm #142

merged 1 commit into from
Sep 21, 2023

Conversation

daemyung
Copy link

🙏 Describe the pull request

RMSNorm is optimized by performing only the necessary boundary checks.

✅ Checklist

  • Code follows the project's coding conventions and style.
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated, if necessary.

@daemyung daemyung added the enhancement New feature or request label Sep 20, 2023
@daemyung daemyung self-assigned this Sep 20, 2023
mejai1206
mejai1206 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@mejai1206 mejai1206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daemyung daemyung merged commit 11421bf into main Sep 21, 2023
@daemyung daemyung deleted the rms_norm branch September 21, 2023 01:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mejai1206 mejai1206 mejai1206 approved these changes

@kakao-steve-ai kakao-steve-ai Awaiting requested review from kakao-steve-ai

Assignees

@daemyung daemyung

Labels
enhancement New feature or request
Projects
Trident
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daemyung @mejai1206