Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Fix a bug in argmax function #143

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fix a bug in argmax function #143

merged 1 commit into from
Sep 22, 2023

Conversation

daemyung
Copy link

🙏 Describe the pull request

argmax function returns wrong results if input has negative values.

✅ Checklist

  • Code follows the project's coding conventions and style.
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated, if necessary.

@daemyung daemyung added the bug Something isn't working label Sep 22, 2023
@daemyung daemyung self-assigned this Sep 22, 2023
kakao-steve-ai
kakao-steve-ai approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@kakao-steve-ai kakao-steve-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mejai1206
mejai1206 approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@mejai1206 mejai1206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daemyung daemyung merged commit a70a73e into main Sep 22, 2023
@daemyung daemyung deleted the argmax branch September 22, 2023 22:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mejai1206 mejai1206 mejai1206 approved these changes

@kakao-steve-ai kakao-steve-ai kakao-steve-ai approved these changes

Assignees

@daemyung daemyung

Labels
bug Something isn't working
Projects
Trident
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daemyung @kakao-steve-ai @mejai1206