This repository has been archived by the owner on Oct 16, 2023. It is now read-only.
Optimize PReLU #144
Merged
Optimize PReLU #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejai1206
force-pushed
the
opt_prelu
branch
from
fb3c973 to
9c55c8e
Compare
daemyung
suggested changes
Sep 25, 2023
trident/kernel/cosine_similarity.py
Outdated
| output_y_size: tl.int32, | ||
| output_x_size: tl.int32, | ||
| size_along_dim: tl.constexpr, |
There was a problem hiding this comment.
์ด ํ์ ์ด ๋ฐ๋ ์ด์ ๊ฐ ์์ด ๋ณด์ด๋๋ฐ์?
There was a problem hiding this comment.
"require_boundary_check": lambda args: args["size_along_dim"] % args["block_size"],
์ฌ๊ธฐ ๋ค์ด๊ฐ๋ ์ฐ์ฐ๋ค์ tl.constexpr์ด์ด์ผ ์ปดํ์ผ๋ ๊ฒฐ์ ๋๋ ๊ฑธ๋ก ์๊ฐํ๋๋ฐ, tl.int32์ด์ด๋ ๋๊ฐ์ ํจ๊ณผ๋ฅผ ์ป์ ์ ์๋๊ฑธ๊น์?
There was a problem hiding this comment.
๋ค ํด๋ ์คํฑ์ CPU์์ ์คํ๋์. tl.constexpr์ GPU ์ปค๋ ์ปดํ์ผ์ ์ํฅ์ ๋ฏธ์น๋๊ฑฐ์์.
There was a problem hiding this comment.
์์ ๋ต๋ต ์์ ํ์์๋๊ฒ ๋ง๊ฒ ๊ตฐ์. ์ด ๋ถ๋ถ์ ๋ค์ ์๋ณตํ์์ต๋๋ค.
mejai1206
force-pushed
the
opt_prelu
branch
from
9c55c8e to
96b34bd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Describe the pull request
PReLU๋ฅผ ์ต์ ํํ์์ต๋๋ค.
๐ฌ Additional context
After
Before
Add any other context or screenshots about the pull request here.
โ Checklist