Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Optimize GroupNorm #146

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Optimize GroupNorm #146

merged 1 commit into from
Sep 25, 2023

Conversation

kakao-steve-ai
Copy link
Contributor

@kakao-steve-ai kakao-steve-ai commented Sep 25, 2023 •
edited
Loading

๐Ÿ™ Describe the pull request

  • GroupNorm์—์„œ boundary check ์ตœ์ ํ™”ํ–ˆ์Šต๋‹ˆ๋‹ค.

before:
before

after:
after

โœ… Checklist

  • Code follows the project's coding conventions and style.
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated, if necessary.

daemyung
daemyung suggested changes Sep 25, 2023
View reviewed changes
trident/kernel/group_norm.py Outdated Show resolved Hide resolved
@kakao-steve-ai kakao-steve-ai marked this pull request as ready for review September 25, 2023 07:41
@kakao-steve-ai kakao-steve-ai added the enhancement New feature or request label Sep 25, 2023
@kakao-steve-ai kakao-steve-ai self-assigned this Sep 25, 2023
daemyung
daemyung suggested changes Sep 25, 2023
View reviewed changes
benchmarks/benchmark_group_norm.py Show resolved Hide resolved
trident/kernel/group_norm.py Outdated Show resolved Hide resolved
daemyung
daemyung suggested changes Sep 25, 2023
View reviewed changes
trident/kernel/group_norm.py Outdated Show resolved Hide resolved
mejai1206
mejai1206 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@mejai1206 mejai1206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

daemyung
daemyung approved these changes Sep 25, 2023
View reviewed changes
Copy link

@daemyung daemyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kakao-steve-ai kakao-steve-ai merged commit e7a61c5 into main Sep 25, 2023
@kakao-steve-ai kakao-steve-ai deleted the group_norm branch September 25, 2023 09:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mejai1206 mejai1206 mejai1206 approved these changes

@daemyung daemyung daemyung approved these changes

Assignees

@kakao-steve-ai kakao-steve-ai

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kakao-steve-ai @daemyung @mejai1206