Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only decrypt calls from gateway urls #126 #137 #146

Closed
wants to merge 1 commit into from
Closed

only decrypt calls from gateway urls #126 #137 #146

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 8, 2016

  • only decrypt calls from gateway urls
  • only decrypt the request if the response contains a command

It use the gatway-urls direct from com2us (#137). So we should not get problems if they update the links. And it also cleans the 1% gap from #126^^

Im not an python pro. So if some one has a better point for storing the gatewayUrls. Plz say hello :).

We could also talk about the gatewayUrls.clear() and the gatewayUrls.add(self.request.url.geturl()). I put this in for the case com2us updates the Serverlist while SWProxy is running. But hands down, how often does they change them AND if they change them a simply SWProxy restart would fix it untile the next update^^. So remove the two lines? This would avoid that the list get cleared and refilled on every login ^^

- only decrypt calls from gateway urls
- only decrypt the request if the response contains a command
@kakaroto
Copy link
Owner

I disagree with this change. While it's nice knowing about the location API, it is completely useless for us. As I said before, we know that all gateway URLs will start with "/api/gateway", and in your change, you just make it start with "/api/location", so you still have a hardcoded path in there.. if the code doesn't catch the "/api/gateway" url (because we assume it's some weird/unusual url), then it still won't catch the "/api/location" one, so it's useless. Also, with your change, if you start SWProxy after the game was started, it means that it won't see the location request, it won't find any urls, so it won't be able to decrypt anything. The way it is now, you can always run SWproxy while the game is running and have it log runs or whatever else you want. Your change prevents that.
Anyways, I don't see a point to all this. While I appreciate the PR/contribution, I don't think anything is needed, since #126 is fixed and closed.

@kakaroto kakaroto closed this Oct 10, 2016
@ghost ghost mentioned this pull request Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant