Add optimizer settings to contract build options #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbroadhurst
approved these changes
Oct 21, 2024
onelapahead
reviewed
Oct 21, 2024
| @@ -258,6 +274,38 @@ func (r *cms_buildResource) Schema(_ context.Context, _ resource.SchemaRequest, | |||
| "commit_hash": &schema.StringAttribute{ | |||
| Computed: true, | |||
| }, | |||
| "optimizer": &schema.SingleNestedAttribute{ | |||
| Optional: true, | |||
| Computed: true, | |||
There was a problem hiding this comment.
I'm not sure if this is computed ? I guess if you don't provide any settings, it will be ?
And I'm not sure how computed interacts with nested attributes, I'd re-run the Terraform a few times around if you haven't already to ensure these attributes behaves idempotently on re-runs. Additionally, I'd make sure to test contracts that left the optimizer empty as well.
There was a problem hiding this comment.
Yeah my terraform know-how isn't great so I'm not sure if computed is correct for the optimizer structure. Here's what I've tested with the current structure:
- Apply a plan that has the
optimizersection defined. Optimizer options are correctly set on the deployed contract. - Re-plan without any changes. TF doesn't think any changes are required.
- Remove the
optimizersection. TF thinks it needs to revert theoptimizersection to its defaults (i.e.off). Deployed contract correctly has optimization options disabled. - Re-plan without any changes. TF doesn't think any changes are required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.