feat: add show_legend_state #1082
Conversation
| @@ -130,6 +130,7 @@ properties of the Entity object detailed in the following table (as per `sensor. | |||
| | unit | string | | Set a custom unit of measurement, overrides `unit` set in base config. | |||
| | aggregate_func | string | | Override for aggregate function used to calculate point on the graph, `avg`, `median`, `min`, `max`, `first`, `last`, `sum`. | |||
| | show_state | boolean | | Display the current state. | |||
| | show_legend_state | boolean | | Display the current state with the legend. | |||
There was a problem hiding this comment.
Even though this is not the case for most of the other entries: please state the default value as false. Let's be a good example. ;-)
| </div> | ||
| `)} | ||
| ${this.visibleLegends.map((entity) => { | ||
| let legend = this.computeName(entity.index); |
There was a problem hiding this comment.
Please properly indent the code.
|
|
||
| const { show_legend_state } = this.config.entities[entity.index]; | ||
| if (show_legend_state) { | ||
| legend += ` (${this.computeState(state)}${this.computeUom(entity.index)})`; |
There was a problem hiding this comment.
Can you put the state in an additional span with a suitable class? (If there already are suitable classes for state and UOM, you could maybe reuse them.)
I think there is a CSS property then to add the braces to the content.
That way users could use card-mod to style the appearance of the state as they wish.
Please make sure the defaults look good in different situations, e.g. long and short state names.
There was a problem hiding this comment.
put the state in an additional span
Absolutely correct.
Also, please think about an order: in some cases a user may want to have UoM before a value.
There was a problem hiding this comment.
I think, a separate span should do the trick for that as well, together with the CSS direction property.
#1081