-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement more group_by options #833
Open
blind-coder
wants to merge
7
commits into
kalkih:dev
Choose a base branch
from
blind-coder:blindcoder/master
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d15804b
Update README.md
ildar170975 f182137
Update README.md
ildar170975 487aa5b
Update README.md
ildar170975 2e14922
Update README.md
ildar170975 f59942d
implement more group_by options
blind-coder 04ba189
requested rework
blind-coder e085d48
correctly calculate for 1 years, and properly use 12 months
blind-coder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -993,6 +993,19 @@ class MiniGraphCard extends LitElement { | |
getEndDate() { | ||
const date = new Date(); | ||
switch (this.config.group_by) { | ||
case 'year': | ||
date.setDate(1); // First day | ||
date.setMonth(0); // of January | ||
date.setHours(0, 0, 0); // 00:00:00 | ||
break; | ||
case 'month': | ||
date.setDate(1); // First day of current month | ||
date.setHours(0, 0, 0); | ||
break; | ||
case 'week': | ||
date.setDate(date.getDate() - date.getDay() + 1); // First day of the week | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just flipped through the PRs here and noticed: should this not be the first day of next week at 0h00? See the date case below... The same applies to month and year. |
||
date.setHours(0, 0, 0); | ||
break; | ||
case 'date': | ||
date.setDate(date.getDate() + 1); | ||
date.setHours(0, 0, 0); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I added the other comment on the code. Here are three more: