Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix core unit tests failing #420

Open
wants to merge 1 commit into
base: MOODLE_401_STABLE
Choose a base branch
from
Open

Fix core unit tests failing #420

wants to merge 1 commit into from

Conversation

djarran
Copy link

@djarran djarran commented Feb 13, 2024

Description: This applies the fixes outlined in #394. This fails this test with the following error message:

1) externallib_test::test_get_courses_by_field
Failed asserting that actual size 7 matches expected size 6.

/var/www/site/course/tests/externallib_test.php:2800
/var/www/site/lib/phpunit/classes/advanced_testcase.php:80

This proposed fix allows the unit test to be ran successfully

@kaltura-hooks
Copy link

Hi @djarran,
Thank you for contributing this pull request!
Please sign the Kaltura CLA so we can review and merge your contribution.
Learn more at http://bit.ly/KalturaContrib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djarran @kaltura-hooks