fix(ADA-1778): [ORS] - Firefox playerkit - Focusable but hidden/unlabeled elements in tabbing order #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eled elements in tabbing order
Tzipi-kaltura
requested review from
SivanA-Kaltura,
lianbenjamin and
semarche-kaltura
SivanA-Kaltura
requested changes
Nov 20, 2024
| @@ -1808,6 +1808,7 @@ export default class Player extends FakeEventTarget { | |||
| const classNameWithId = `${ENGINE_CLASS_NAME}-${this._engine.id}`; | |||
| Utils.Dom.addClassName(engineEl, classNameWithId); | |||
| Utils.Dom.prependTo(engineEl, this._el); | |||
| Utils.Dom.setAttribute(engineEl, 'tabindex', '-1'); | |||
There was a problem hiding this comment.
why does this fix the problem ?
There was a problem hiding this comment.
Firefox treats video element as a focusable element (don't know why but it happens in all video elements) if you will add tabIndex="-1" so explicitly it is not focusable element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue:
When enable the "Show Tabbing Order" in Firefox browser, tab marker is shown on the video element.
Fix:
Add tabIndex="-1" on the video element
solves ADA-1788
CheckLists