Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (SUP-46985): Replay button unresponsive when PiP is activated #809

Merged
merged 5 commits into from
Feb 25, 2025
+21 −0
Merged

fix (SUP-46985): Replay button unresponsive when PiP is activated #809

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
17745fb
Update html5.ts
yambenari24 Feb 20, 2025
6dfbeff
Update html5.ts
yambenari24 Feb 20, 2025
4dbeed0
Update html5.ts
yambenari24 Feb 24, 2025
a2cab4b
Update html5.ts
yambenari24 Feb 25, 2025
3448e97
Update html5.ts
yambenari24 Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
Update html5.ts
@yambenari24
yambenari24 committed Feb 25, 2025
commit 3448e973d8678bc081f7aefafb436d8d6a9efa57
3 changes: 1 addition & 2 deletions src/engines/html5/html5.ts
View file
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@ import { CapabilityResult, ICapability } from '../../types';
import { PKABRRestrictionObject, PKDrmConfigObject, PKDrmDataObject, PKMediaSourceObject, PKVideoElementStore } from '../../types';
import { IEngine } from '../../types';
import Track from '../../track/track';
import { Env } from '../../../src/playkit';
import Env from '../../../src/utils/env';

const SHORT_BUFFERING_TIMEOUT: number = 200;

@@ -526,7 +526,6 @@ export default class Html5 extends FakeEventTarget implements IEngine {
const durationMs = Math.round(this._el.duration * 1000);

if (currentTimeMs >= durationMs || this._el.ended) {
this._el.pause();
this._el.currentTime = 0;
}
}