Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tucana 20.16.0 plat 24907 update legacy ep partners #12821

Open
wants to merge 3 commits into
base: Tucana-20.17.0
Choose a base branch
from

Conversation

danbar0kal
Copy link
Collaborator

No description provided.

@danbar0kal danbar0kal changed the base branch from Tucana-20.16.0 to Tucana-20.17.0 July 30, 2024 06:09
@@ -82,7 +82,7 @@ class Partner extends BasePartner

const PARTNER_MAX_LIVE_STREAM_INPUTS_DEFAULT = 10;

const PARTNER_MAX_LIVE_STREAM_OUTPUTS_DEFAULT = 10;
const PARTNER_MAX_LIVE_STREAM_OUTPUTS_DEFAULT = 15;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will effect all partners so dont change it

*
*
* Examples:
* php enableEventPlatformPermissionToPartners.php
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not the name of the script

$eventPlatformPermission = PermissionPeer::getByNameAndPartner(FEATURE_EVENT_PLATFORM_PERMISSION, $partner->getId());
if ($eventPlatformPermission && $eventPlatformPermission->getStatus() == PermissionStatus::ACTIVE)
{
updateMaxLiveStreamOutputs($partner, $eventPlatformPermission->getStatus());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont see any reason to pass the status to the funciton, you dont really need it and if we want to have a debug print we can just have it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants