feat[bckend-middleware]:Implemented custom middleware to check for blacklisted access tokens in Redis. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shikharpa
requested review from
yogai53,
yaju09 and
elizabeththomas92
as code owners
…acklisted access tokens in Redis.
shikharpa
force-pushed
the
feat/custom-token-middleware
branch
from
185897d
to
d4c34e9
Compare
yogai53
requested changes
Apr 9, 2024
| return self.get_response(request) | ||
| token = auth_header.split()[1] | ||
| token_obj = str(AccessToken(token)) | ||
| redis_conn = get_redis_connection() |
There was a problem hiding this comment.
Create a separate class for Redis in a separate file and implement the logic there.
There was a problem hiding this comment.
there should be separate file for redis config too and blacklisting refresh token too, I am thinking raising seperate PR for this , kinda chore/refactor tasks. I will put everything related to redis at one place.
There was a problem hiding this comment.
what is your view on this?
| # Blacklist tokens in Redis | ||
| refresh_exp_time = int(settings.SIMPLE_JWT['REFRESH_TOKEN_LIFETIME'].total_seconds()) | ||
| access_exp_time = int(settings.SIMPLE_JWT['ACCESS_TOKEN_LIFETIME'].total_seconds()) | ||
| with redis_conn.pipeline() as pipe: |
There was a problem hiding this comment.
Create a separate class for Redis in a separate file and implement the logic there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a custom middleware to check for blacklisted access tokens in Redis. The middleware intercepts incoming requests and verifies the validity of access tokens against a blacklist stored in Redis. If a token is found to be blacklisted, the middleware rejects the request with a 401 Unauthorized status code.
Summary
Depends on