queue #12
Open
queue #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Console.WriteLine(queue.Dequeue()); | ||
| Console.WriteLine(queue.Dequeue()); | ||
| Console.WriteLine(queue.Dequeue()); | ||
| Console.WriteLine(queue.Dequeue()); No newline at end of file |
There was a problem hiding this comment.
Это не нужно. Собирайте библиотеку и проверяйте работоспособность тестами
Comment on lines
+1
to
+3
| using System.Security; | ||
|
|
||
| namespace DataStructures; |
There was a problem hiding this comment.
- Не хватает заголовка с информацией о лицензии
- namespace обычно пишут первой содержательной строкой в файле, сразу после лицензии, а using-и уже внутри
|
|
||
| namespace DataStructures; | ||
|
|
||
| public class Queue<T>(int startCapacity = 1) |
| public class Queue<T>(int startCapacity = 1) | ||
| { | ||
| private Tuple<T, int>[] heap = new Tuple<T, int>[startCapacity]; | ||
| public int CurrentCapacity = startCapacity; |
There was a problem hiding this comment.
public-полей быть не должно вообще
|
|
||
| public class Queue<T>(int startCapacity = 1) | ||
| { | ||
| private Tuple<T, int>[] heap = new Tuple<T, int>[startCapacity]; |
There was a problem hiding this comment.
Tuple в современном C# не нужны, есть кортежи
| namespace DataStructures; | ||
|
|
||
| [System.Serializable] | ||
| public class QueueIsEmtpyException : System.Exception |
There was a problem hiding this comment.
Suggested change
| public class QueueIsEmtpyException : System.Exception | |
| public class QueueIsEmptyException : System.Exception |
| { | ||
| Assert.That(queue.Dequeue, Is.EqualTo(answers[i])); | ||
| } | ||
| } |
There was a problem hiding this comment.
Тестов негусто. В частности, интересно поведение при одинаковых приоритетах
| { | ||
| if (Empty()) | ||
| { | ||
| throw new QueueIsEmtpyException("Queue is empty"); |
There was a problem hiding this comment.
Делать эту проверку в Enqueue, очевидно, неправильно :) Из-за неё тесты не проходят.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.