Binary representation #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firsov62121
reviewed
Oct 14, 2023
There was a problem hiding this comment.
В PR не должно быть изменений в файлах, не связанных с задачей.
|
|
||
| #define SIZE sizeof(int) * 8 | ||
|
|
||
| int decimalToBinary(int number, int answer[]); |
There was a problem hiding this comment.
Принято передавать массив в функцию по указателю
| if (!test()) | ||
| { | ||
| printf("Похоже, что сейчас программа не работает корректно"); | ||
| return 1; |
There was a problem hiding this comment.
коды ошибок и возврата выносим в define
Comment on lines
+49
to
+53
| int exp = 2; | ||
| for (int i = 0; i < SIZE; ++i) | ||
| { | ||
| exp = exp * 2; | ||
| } |
| int elementsScanned1 = scanf("%d", &number1); | ||
| if (elementsScanned1 != 1) | ||
| { | ||
| printf("Похоже, что-то пошло не так\n"); |
There was a problem hiding this comment.
"Похоже, что-то пошло не так\n" нужно вынести в константу
Comment on lines
+261
to
+266
| if (!(test1 == binaryToDecimal(binary1)) * (test2 == binaryToDecimal(binary2)) * (test3 == binaryToDecimal(binary3)) * (test4 == binaryToDecimal(binary4))) | ||
| { | ||
| return false; | ||
| } | ||
|
|
||
| return true; |
There was a problem hiding this comment.
убрать if, нормально написать конъюнкцию через &&
Comment on lines
+286
to
+291
| if (!(test1 * test2 * test3)) | ||
| { | ||
| return false; | ||
| } | ||
|
|
||
| return true; |
There was a problem hiding this comment.
убрать if, нормально написать конъюнкцию через &&
| return true; | ||
| } | ||
|
|
||
| bool testStarterAddition(int a, int b, int answer) |
Comment on lines
+320
to
+325
| if (decimalAnswer != answer) | ||
| { | ||
| return false; | ||
| } | ||
|
|
||
| return true; |
| } | ||
|
|
||
| return true; | ||
| } No newline at end of file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.