Поиск подстроки #27
Open
Поиск подстроки #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firsov62121
reviewed
Dec 11, 2023
| { | ||
| return MEMORY_ERROR; | ||
| } | ||
| char *text = readFile(FILE_NAME); |
semester_1/Homework11/src/readFile.c
Outdated
| } | ||
|
|
||
| return str; | ||
| } No newline at end of file |
semester_1/Homework11/src/readFile.c
Outdated
Comment on lines
19
to
22
| if (str == NULL) | ||
| { | ||
| exit(MEMORY_ERROR); | ||
| } |
There was a problem hiding this comment.
вот такие приколы лучше не делать в функциях, которые могут вызываться в произвольном участке программы, когда мы ещё не сохранили данные и не почистили память в вызывающем коде
Comment on lines
12
to
15
| if (file == NULL) | ||
| { | ||
| exit(FILE_ERROR); | ||
| } |
There was a problem hiding this comment.
тут аналогично - просто вернуть NULL
Comment on lines
26
to
37
| else | ||
| { | ||
| if (len != 0) | ||
| { | ||
| len = lps[len - 1]; | ||
| } | ||
| else | ||
| { | ||
| lps[i] = 0; | ||
| ++i; | ||
| } | ||
| } |
| static size_t *createLPSArray(char const *const pattern, const size_t pLength) | ||
| { | ||
| size_t len = 0; | ||
| size_t *lps = (size_t *)malloc(pLength * sizeof(size_t)); |
semester_1/Homework11/src/test.c
Outdated
Comment on lines
25
to
31
| if (text == NULL) | ||
| { | ||
| free(pattern); | ||
| fclose(testFile); | ||
| return false; | ||
| } | ||
| fclose(testFile); |
| return false; | ||
| } | ||
|
|
||
| FILE *answerFile = fopen(answerFileName, "r"); |
semester_1/Homework11/src/test.c
Outdated
|
|
||
| FILE *answerFile = fopen(answerFileName, "r"); | ||
| size_t answer = 0; | ||
| int scanfCheck = fscanf(answerFile, "%lu", &answer); |
| } | ||
| } | ||
| free(lps); | ||
| return -1; |
There was a problem hiding this comment.
size_t - unsigned long -> переделать size_t на long
Firsov62121
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.