Task2 #29
Open
Task2 #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+12
to
+16
| // if (!test()) | ||
| // { | ||
| // printf("Программа не работает\n"); | ||
| // return PROGRAM_FAILED_TESTS; | ||
| // } |
There was a problem hiding this comment.
Закомментированный код не нужен
| Node *head; | ||
| } Queue; | ||
|
|
||
| Queue *createQueue(void){ |
There was a problem hiding this comment.
Suggested change
| Queue *createQueue(void){ | |
| Queue *createQueue(void) | |
| { |
| return (Queue *)calloc(1, sizeof(Queue)); | ||
| } | ||
|
|
||
| ErrorCode enqueue(Queue * const queue,const int value, const size_t priority) |
There was a problem hiding this comment.
Suggested change
| ErrorCode enqueue(Queue * const queue,const int value, const size_t priority) | |
| ErrorCode enqueue(Queue * const queue, const int value, const size_t priority) |
| free(currentNode); | ||
| } | ||
| free(queue); | ||
| queue = NULL; |
There was a problem hiding this comment.
Оно так не работает. Надо было принимать queue как Queue**, иначе тут просто в локальный параметр запишется NULL, и вызывающий про это ничего не узнает
|
|
||
| typedef struct Queue Queue; | ||
|
|
||
| ErrorCode enqueue(Queue * const queue,const int value, const size_t priority); |
There was a problem hiding this comment.
Надо было комментарии к каждой функции в заголовочном файле
| } Command; | ||
|
|
||
| const bool testCase(Command const *const commands, size_t const *const priorities, | ||
| int const *const answers, const size_t testLen, const int * const values) |
There was a problem hiding this comment.
Тут надо отступ, потому что это продолжение предыдущей строки.
Comment on lines
+59
to
+62
| const bool test(void) | ||
| { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Всё для тестов написали, а сами тесты — нет. Обидно :)
| #define PROGRAM_FAILED_TESTS 1 | ||
| #define MEMORY_ERROR 2 | ||
|
|
||
| int main(int, char **) |
There was a problem hiding this comment.
Оно так не умеет, надо имена параметров или убрать их вовсе
| Node *head; | ||
| } Queue; | ||
|
|
||
| Queue *createQueue(void){ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.