qsort task completed #7

kamendov-maxim · 2023-10-04T17:22:32Z

No description provided.

Firsov62121 · 2023-10-13T22:42:31Z

semester_1/homework3/qsort.c

+#include <stdlib.h>
+#include <stdbool.h>
+
+int partition(int array[], int leftElement, int rightElement);


Принято передавать массив в функцию по указателю
Размеры и индексы храним в size_t.
Везде, где мы не собираемся менять указатель, освобождать по нему дынные, нужно использовать type * const.

Firsov62121 · 2023-10-13T22:42:46Z

semester_1/homework3/qsort.c

+bool checkIfArrayIsSorted(int array[], int size);
+bool testStarterForArrays(int testArray[], int answerArray[], int size);
+
+int main()


main() -> main(void)

Firsov62121 · 2023-10-13T22:42:58Z

semester_1/homework3/qsort.c

+{
+   if (!test())
+   {
+      return 1;


коды ошибок и возврата выносим в define, если это не номер сломавшегося теста

Firsov62121 · 2023-10-13T22:43:40Z

semester_1/homework3/qsort.c

+   }
+
+   printf("\nEnter the size of your array: ");
+   int size = 0;


смотри прошлую задачу (size_t)

Firsov62121 · 2023-10-13T22:44:42Z

semester_1/homework3/qsort.c

+      scanf("%d", &size);
+   }
+
+   int *array = malloc(size * sizeof(int));


нет явного приведения к (int *) перед malloc

Firsov62121 · 2023-10-13T22:50:38Z

semester_1/homework3/qsort.c

+int binarySearch(int array[], int elementWeAreLookingFor, int leftEdge, int rightEdge)
+{
+   while (leftEdge <= rightEdge)
+   {
+      int middleElement = leftEdge + (rightEdge - leftEdge) / 2;
+
+      if (array[middleElement] == elementWeAreLookingFor)
+      {
+         return middleElement;
+      }
+
+      if (array[middleElement] < elementWeAreLookingFor)
+      {
+         leftEdge = middleElement + 1;
+      }
+
+      else
+      {
+         rightEdge = middleElement - 1;
+      }
+   }
+
+   return -1;
+}


Эта функция тут не нужна

и тесты для неё тоже

Firsov62121 · 2023-10-13T22:52:38Z

semester_1/homework3/qsort.c

+
+bool test(void)
+{
+   if (!(testSwapFunction() * testPartitionFunction() * testSmartQuickSort()))


убрать if, написать нормально через &&

Firsov62121 · 2023-10-13T22:53:01Z

semester_1/homework3/qsort.c

+   if (firstValue != 1 || secondValue != 0)
+   {
+      return false;
+   }
+   return true;


это if ну нужен

Firsov62121 · 2023-10-13T22:53:47Z

semester_1/homework3/qsort.c

+   if (!(testStarterForArrays(testArray1, answerArray1, 9) * testStarterForArrays(testArray2, answerArray2, 6) * testStarterForArrays(testArray3, answerArray3, 5) * testStarterForArrays(testArray4, answerArray4, 1)))
+   {
+      return false;
+   }
+
+   return true;


убрать if, написать через &&

Firsov62121 · 2023-10-13T22:54:30Z

semester_1/homework3/qsort.c

+   if (!(testStarterForArrays(testArray1, answerArray1, 5) * testStarterForArrays(testArray2, answerArray2, 5) * testStarterForArrays(testArray3, answerArray3, 1)))
+   {
+      return false;
+   }
+
+   return true;


убрать if, написать через &&

Firsov62121 · 2023-12-05T18:09:45Z

semester_1/homework3/qsort.c

+
+const bool test(void);
+
+static void printArray(int *array, size_t size)


const int * const

Firsov62121 · 2023-12-05T18:09:59Z

semester_1/homework3/qsort.c

+   printf("\n");
+}
+
+static void swap(int *firstValue, int *secondValue)


int * const

Firsov62121 · 2023-12-05T18:10:13Z

semester_1/homework3/qsort.c

+   *secondValue = buffer;
+}
+
+static size_t partition(int *array, size_t leftElement, size_t rightElement)


int * const

Firsov62121 · 2023-12-05T18:10:38Z

semester_1/homework3/qsort.c

+   return i;
+}
+
+static void insertSort(int array[], int leftElement, int rightElement)


int * const

size_t для индексов

Firsov62121 · 2023-12-05T18:10:54Z

semester_1/homework3/qsort.c

+   }
+}
+
+static void smartQuickSort(int array[], int leftElement, int rightElement)


int * const

size_t для индексов

Firsov62121 · 2023-12-05T18:12:24Z

semester_1/homework3/qsort.c

+   {
+      printf("Enter %lu number of your array: ", i + 1);
+      int currentNumber = 0;
+      scanf("%d", &currentNumber);


убрать currentNumber

Firsov62121 · 2023-12-05T18:13:36Z

semester_1/homework3/qsort.c

+   partition(testArray3, 0, 5);
+   partition(testArray4, 0, 1);
+
+   return testStarterForArrays(testArray1, answerArray1, 9) && testStarterForArrays(testArray2, answerArray2, 6) && testStarterForArrays(testArray3, answerArray3, 5) && testStarterForArrays(testArray4, answerArray4, 1);


80 символов в строке максимум - разбить на 2 строки

Firsov62121 · 2023-12-05T18:13:41Z

semester_1/homework3/qsort.c

+
+   smartQuickSort(testArray3, 0, 1 - 1);
+
+   return testStarterForArrays(testArray1, answerArray1, 5) && testStarterForArrays(testArray2, answerArray2, 5) && testStarterForArrays(testArray3, answerArray3, 1);


см. выше

Firsov62121 · 2023-12-05T18:14:41Z

semester_1/homework3/qsort.c

+   return firstValue == 1 && secondValue == 0;
+}
+
+static const bool testStarterForArrays(int testArray[], int answerArray[], int size)


const int * const
size_t для индексов
testStarterForArrays -> compareArrays

Firsov62121 · 2023-12-05T18:16:37Z

semester_1/homework3/qsort.c

+   int size = 0;
+   while (size <= 0)
+   {
+      printf("Enter the size of your array: ");
+      if (scanf("%d", &size) != 1)
+      {
+         return INPUT_ERROR;
+      }
+      if (size <= 0)
+      {
+         printf("\nSize of your array should be at least 1\n");
+      }
+   }


size_t
%d -> %lu

Firsov62121 · 2023-12-06T19:13:25Z

semester_1/homework3/qsort.c

+   return i;
+}
+
+static void insertSort(int *const array, int leftElement, size_t rightElement)


Firsov62121 · 2023-12-06T19:13:44Z

semester_1/homework3/qsort.c

+
+static void insertSort(int *const array, int leftElement, size_t rightElement)
+{
+   for (int i = leftElement + 1; i < rightElement; ++i)


Firsov62121 · 2023-12-06T19:14:32Z

semester_1/homework3/qsort.c

+   partition(testArray3, 0, 5);
+   partition(testArray4, 0, 1);
+
+   return compareArrays(testArray1, answerArray1, 9) && compareArrays(testArray2, answerArray2, 6) && compareArrays(testArray3, answerArray3, 5) && compareArrays(testArray4, answerArray4, 1);


разбить на 2 строки

Firsov62121 · 2023-12-06T19:14:58Z

semester_1/homework3/qsort.c

+   smartQuickSort(testArray2, 0, 5 - 1);
+   smartQuickSort(testArray3, 0, 1 - 1);
+
+   return compareArrays(testArray1, answerArray1, 5) && compareArrays(testArray2, answerArray2, 5) && compareArrays(testArray3, answerArray3, 1);


разбить на 2 строки

Firsov62121 · 2023-12-06T19:15:46Z

semester_1/homework3/qsort.c

+   while (size <= 0)
+   {
+      printf("Enter the size of your array: ");
+      if (scanf("%lu", &size) != 1)
+      {
+         return INPUT_ERROR;
+      }
+      if (size <= 0)
+      {
+         printf("\nSize of your array should be at least 1\n");
+      }
+   }


size_t - unsigned long - всегда неотрицательный
в данном случае никогда не зайдём в цикл

Firsov62121 · 2023-12-13T11:36:08Z

semester_1/homework3/qsort.c

+   partition(testArray2, 0, 6);
+   partition(testArray3, 0, 5);
+   partition(testArray4, 0, 1);
+


Всё ещё нет разбиения на 2 строки тут и ниже в return

qsort task completed

9debd15

Firsov62121 reviewed Oct 13, 2023

View reviewed changes

kamendov-maxim added 2 commits December 5, 2023 19:59

Исправления

af2073c

Исправления

7bd2d3a

Firsov62121 reviewed Dec 5, 2023

View reviewed changes

Исправления

c260b2b

Firsov62121 reviewed Dec 6, 2023

View reviewed changes

Исправления

1202dcc

Firsov62121 reviewed Dec 13, 2023

View reviewed changes


		const bool test(void);

		static void printArray(int *array, size_t size)


		smartQuickSort(testArray3, 0, 1 - 1);

		return testStarterForArrays(testArray1, answerArray1, 5) && testStarterForArrays(testArray2, answerArray2, 5) && testStarterForArrays(testArray3, answerArray3, 1);

Uh oh!

qsort task completed #7

Are you sure you want to change the base?

qsort task completed #7

Uh oh!

Conversation

kamendov-maxim commented Oct 4, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants