Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teams communication adapter #4965

Closed
wants to merge 6 commits into from

Conversation

capaj
Copy link
Contributor

@capaj capaj commented Jun 13, 2024

Background

closes #4538

This is how it looks when you add/remove a channel:

image

This is how a schema change looks in teams

image

on FE I have added a link to the guide how to setup webhook in ms teams:
image

once you add your URL it goes like this:
image

Description

Mostly just added a new CommunicationAdapter and extended BE/FE code which was assuming we only have two adapters

Testing

if you want to test on your local, you can use my ms teams webhook:
https://jspac.webhook.office.com/webhookb2/d11d2f0d-7820-4684-b721-e0d8e9a94ab8@4b220568-ffe7-4204-a3c5-5c6bebc60ab9/IncomingWebhook/1a693644edbc449c8a1ce9306d9c13ef/4a134898-79cd-4a70-9405-abfecd2879f4

Checklist

  • Input validation
  • Output encoding
  • Authentication management
  • Session management
  • Access control
  • Cryptographic practices
  • Error handling and logging
  • Data protection
  • Communication security
  • System configuration
  • Database security
  • File management
  • Memory management
  • Testing

Copy link

changeset-bot bot commented Jun 13, 2024

⚠️ No Changeset found

Latest commit: 02bddbb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@capaj capaj force-pushed the TeamsCommunicationAdapter branch from b0deb6e to e45e596 Compare June 13, 2024 08:55
@capaj capaj force-pushed the TeamsCommunicationAdapter branch from e45e596 to f604703 Compare June 13, 2024 09:00
@@ -0,0 +1,192 @@
<?xml version="1.0" encoding="UTF-8"?><rss xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:content="http://purl.org/rss/1.0/modules/content/" xmlns:atom="http://www.w3.org/2005/Atom" version="2.0">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should be gitignored tho

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove it

@capaj
Copy link
Contributor Author

capaj commented Jun 13, 2024

will reopen from this repo so that CI can run

@capaj capaj closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support MS Teams as a first-class notification/alert target
2 participants