-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly parse unsigned integer trace id #1305
Properly parse unsigned integer trace id #1305
Conversation
LGTM but the maintainers will have to have a look. Maybe @hughsimpson ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't tell you how many times I've had to override this behaviour myself, At least twice,
These flaky tests are killing me, I'm going to try to make them more reliable before merging this |
Merged! Will cut a release with this soon |
Hi @hughsimpson , do you know when the new version will be released? We are facing this issue in production and will be helpful if we can have this fix. Thanks! |
* Fix issue * import Long * Add tests * fix test name * checking upper bound * fix tests --------- Co-authored-by: Vivek Mahajan <[email protected]> Co-authored-by: hughsimpson <[email protected]>
decodeUnsignedLongToHex
throws anNumberFormatException
e.gjava.lang.NumberFormatException: For input string: "14293359187408121545"