Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pekko-grpc instrumentation #1307

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

inobu
Copy link
Contributor

@inobu inobu commented Oct 20, 2023

Summary

Add instrumentation for pekko-grpc

Example

I did publishLocal and use it
In our environment, It works like this
スクリーンショット 2023-10-20 18 51 05

@inobu inobu force-pushed the add-pekko-grpc-instrumentation branch from 1377664 to 1bd9cd0 Compare October 20, 2023 09:46
@inobu inobu changed the title [WIP] add-pekko-grpc-instrumentation feat: add pekko-grpc instrumentation Oct 20, 2023
@inobu inobu marked this pull request as ready for review October 20, 2023 09:48
@inobu
Copy link
Contributor Author

inobu commented Oct 20, 2023

@dvgica
Copy link
Contributor

dvgica commented Oct 20, 2023

@inobu, of that list only Hugh is a maintainer. That said, the rest of us would love to see support for Pekko gRPC. We're currently using an internal fork of https://github.com/nezasa/kamon-akka-grpc with Akka swapped for Pekko.

Copy link
Contributor

@hughsimpson hughsimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit 👍

@hughsimpson hughsimpson merged commit 305b2c5 into kamon-io:master Oct 23, 2023
1 check passed
@inobu inobu deleted the add-pekko-grpc-instrumentation branch October 24, 2023 02:56
hughsimpson pushed a commit to hughsimpson/Kamon that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants