Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private Datasets: commands auth checks #1009

Draft
wants to merge 4 commits into
base: feature/private-datasets
Choose a base branch
from
Draft

Private Datasets: commands auth checks #1009

wants to merge 4 commits into from

Conversation

s373r
Copy link
Member

@s373r s373r commented Dec 23, 2024

Changed

  • Private Datasets:
    • E2E: added the ability to create an account using CLI

@s373r s373r self-assigned this Dec 23, 2024
s373r
s373r commented Dec 23, 2024
View reviewed changes
Copy link
Member Author

@s373r s373r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a note for readers

src/domain/core/src/auth/dataset_action_authorizer.rs
{
fn filtered_datasets_stream<'a>(
&'a self,
mut handles: AllOwnedAndPotentiallyRelatedDatasetHandlesResult<'a>,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to readers: in search of a better name than AllOwnedAndPotentiallyRelatedDatasetHandlesResult.

s373r
s373r commented Dec 23, 2024
View reviewed changes
src/domain/core/src/auth/dataset_action_authorizer.rs
T: DatasetActionAuthorizer,
T: ?Sized,
{
fn filtered_datasets_stream<'a>(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to readers: in search of a better name than filtered_datasets_stream as well.

@s373r s373r force-pushed the chore/commands-auth-checks branch 3 times, most recently from baae50b to 5993b31 Compare December 24, 2024 20:12
@s373r s373r force-pushed the chore/commands-auth-checks branch from 5993b31 to dde1bb8 Compare December 25, 2024 16:45
@s373r s373r force-pushed the chore/commands-auth-checks branch from dde1bb8 to 3870bbd Compare December 25, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaychenko-sergei zaychenko-sergei Awaiting requested review from zaychenko-sergei

Assignees

@s373r s373r

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@s373r