-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
979 isolate low level dataset storage repositories in a new crate and name key traits to emphasize storage aspect #1018
Draft
zaychenko-sergei
wants to merge
11
commits into
master
Choose a base branch
from
979-isolate-low-level-dataset-storage-repositories-in-a-new-crate-and-name-key-traits-to-emphasize-storage-aspect
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaychenko-sergei
force-pushed
the
979-isolate-low-level-dataset-storage-repositories-in-a-new-crate-and-name-key-traits-to-emphasize-storage-aspect
branch
from
December 27, 2024 11:02
bcdb981
to
47e845c
Compare
Extracted `AsyncReadObj` to `async_utils` crate, `S3Context` to `aws_utils` crate AccessError became part of odf ODF crates new structure: - src/domain/odf/odf-metadata (old opendatafabric) - src/domain/odf/odf-storage (repository interfaces) - src/infra/odf-storage (repository implementations). Moved `NamedObjectReppository` for now from `core` - with all implementations and tests. aws-utils` renamed to `s3-utils`. Moved `ObjectRepository` Moved ReferenceRepository and BlockRef Moved MetadataBlockRepository ObjectStoreRegistry separated Moved `MetadataChain` and it's visitors + `MetadataFactory` testing tools Moved `DatasetSummary` More odf catalogs reshuffling Started `odf/dataset` crate, moved `DatasetSummary` there Moved `MetadataChain` to `odf-dataset` Moved `BlockRef` into `odf-dataset` Moved `Dataset` to `odf-dataset` Moved `DatasetFactory` & `OdfServerAccessTokenResolver` to `odf-dataset` `DatasetStorageUnit` is a new name for `DatasetRepository` Renamed storage unit methods opendatafabric => odf_metadata Started defining `odf` metacrate. Converted uses of `odf_dataset`, `odf_metadata` in `adapter/auth-oso`, `adapter-graphl`. odf meta-crate applied in adapter/http odf meta-crate used in adapter/odata, adapter/oauth Use odf meta-crate in app/cli Applied odf meta-crate in all domains except core Using odf meta-crate in domain/core Web-UI build correction
zaychenko-sergei
force-pushed
the
979-isolate-low-level-dataset-storage-repositories-in-a-new-crate-and-name-key-traits-to-emphasize-storage-aspect
branch
from
December 27, 2024 11:38
47e845c
to
6537db5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #979
Checklist before requesting a review