-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Won't Load Previous Messages #358
Comments
Have you pulled in the latest? I know there was an issue there before that should have been solved in #350. Does the rails server log report any errors? |
No errors logged that I can tell, I have the latest. What's the file path I
|
The filepath to watch for logging if on development would be development.log (ie, As for why it's not loading earlier messages, it's hard to tell. Did you try different browsers? Are you running it on a nonstandard configuration? (I know you have another issue on running it with Phusion Passenger and nginx -- could it be related to that?) |
I'll check development.log, in this case I'm just using thin+nginx. Running
|
@scouttyg I'm not finding a |
Here's my
|
Looks like logs only print to
|
No errors come through.
|
It very well might be issues with Faye. When you hit earlier messages, you should see a method kind of like mine that I listed: IE the app should be hitting ActivitiesController#Index with an "oldest" parameter (it's querying for earlier messages). If it's not doing that, there might be something bigger at play there. |
It seems like the issue goes away when I don't have nginx in front of kandan ... maybe nginx is messing up Faye? Sounds like my other issue: #355 but without Passenger this time. |
@scouttyg I made a discovery. It seems to be isolated to when my browser is a certain height. I have vertical monitors so my browser real-estate is:
If I bring down the size of the window, scroll to the bottom, and then begin to scroll up, then messages begin to load. |
That's actually good to hear, because I was definitely getting stumped. I'll check it out and see if I can replicate that! |
Ah, I think I figured it out -- so Kandan by default only shows the last X messages, and at the top of the container has a "Loading more messages" div constantly there. The idea being that as a user scrolls up, it will trigger the load of more messages. The code for that is: $container.bind 'scroll', =>
if $container.scrollTop() <= 100 && !@loading_new_messages
@loading_new_messages = true
@loadMoreActivities($container)
return It binds the "load more activities" action to the scroll as you can see. The issue with that is that if you're able to load all the activities in your window at once to display (ie, a vertical display, or if you are zoomed out enough), there will be nothing to scroll -- so the "load more activities" action doesn't get loaded. I'll see if I can fix this. |
Also noticed that on initial load at this browser size, the chat does not go all the way down to the bottom. After I resize and scroll down, then scroll up, and re-maximize, it all gets fixed. Notice in my example, the initial |
As a temporary fix for this, you should be able to change the file |
Loading previous messages
continues spinning and never loads previous messages:The text was updated successfully, but these errors were encountered: