Fixed container so that it would load extra messages if it detected that... #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat a scroll bar was not present on the container
| if !$container.hasScrollBar() | ||
| @loading_new_messages = true; | ||
| @loadMoreActivities($container) | ||
|
|
||
| $container.bind 'scroll', => |
There was a problem hiding this comment.
When we bind to the "scroll" event, we have to make sure a scroll bar is actually present or it will never trigger. In the case of #358, the user had a vertical monitor which didn't allow for a scroll bar to appear. Thus, they couldn't scroll to trigger new messages.
fusion94
pushed a commit
that referenced
this pull request
May 15, 2014
Fixed container so that it would load extra messages if it detected that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... a scroll bar was not present on the container