Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KnightForge theme #1

Merged
merged 22 commits into from
Nov 14, 2024
Merged

KnightForge theme #1

merged 22 commits into from
Nov 14, 2024

Conversation

yar2000T
Copy link
Contributor

Added KnightForge theme

@yar2000T yar2000T changed the title Patch 1 KnightForge theme Nov 13, 2024
@Schneegans
Copy link
Contributor

Hi there! Thanks a lot! Following our discussion, I made this repository compliant with the REUSE specification. It would be cool, if you could merge main into your branch and make sure to add the corresponding SPDX-tags to your files. For the images you can use a REUSE.toml file as it's now done in the Minecraft theme.

For possible SPDX-FileCopyrightText see here: https://reuse.software/spec-3.2/#format-of-copyright-notices

So if the file is based on one of the Minecraft-theme files, the header should be something like:

/* SPDX-FileCopyrightText: yar2000T <https://github.com/yar2000T> */
/* SPDX-FileCopyrightText: Simon Schneegans <[email protected]> */
/* SPDX-License-Identifier: CC-BY-4.0 */

Or whatever you prefer for the copyright text for yourself.

@yar2000T
Copy link
Contributor Author

So, I need to add REUSE.toml to my pull request, right?

@Schneegans
Copy link
Contributor

Yes, it is the easiest way. The REUSE specification says that there must be a clear license and copyright holder(s) specified for each file. For text files, you can do this via the SPDX tags, for binary files like the font or image files this can be done via such a REUSE.toml file.

@yar2000T
Copy link
Contributor Author

Finally, I committed all necessary files and modified the readme (I don't know what to write in the table theme(description))

Copy link
Contributor

@Schneegans Schneegans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! I added two notes!

KnightForge/REUSE.toml Outdated Show resolved Hide resolved
KnightForge/theme.json5 Outdated Show resolved Hide resolved
Comment on lines 1 to 2
// SPDX-FileCopyrightText: yar2000T <https://github.com/yar2000T>
// SPDX-License-Identifier: CC-BY-4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think // is not a valid comment in CSS. And the CC-BY obliges you to name the original author. So this would be correct in this case:

Suggested change
// SPDX-FileCopyrightText: yar2000T <https://github.com/yar2000T>
// SPDX-License-Identifier: CC-BY-4.0
/* SPDX-FileCopyrightText: yar2000T <https://github.com/yar2000T> */
/* SPDX-FileCopyrightText: Simon Schneegans <[email protected]> */
/* SPDX-License-Identifier: CC-BY-4.0 */

@Schneegans Schneegans merged commit 0845130 into kando-menu:main Nov 14, 2024
1 check passed
@yar2000T yar2000T deleted the patch-1 branch November 14, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants