-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KnightForge theme #1
Conversation
Hi there! Thanks a lot! Following our discussion, I made this repository compliant with the REUSE specification. It would be cool, if you could merge For possible SPDX-FileCopyrightText see here: https://reuse.software/spec-3.2/#format-of-copyright-notices So if the file is based on one of the Minecraft-theme files, the header should be something like: /* SPDX-FileCopyrightText: yar2000T <https://github.com/yar2000T> */
/* SPDX-FileCopyrightText: Simon Schneegans <[email protected]> */
/* SPDX-License-Identifier: CC-BY-4.0 */ Or whatever you prefer for the copyright text for yourself. |
So, I need to add REUSE.toml to my pull request, right? |
Yes, it is the easiest way. The REUSE specification says that there must be a clear license and copyright holder(s) specified for each file. For text files, you can do this via the SPDX tags, for binary files like the font or image files this can be done via such a |
Finally, I committed all necessary files and modified the readme (I don't know what to write in the table theme(description)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again! I added two notes!
KnightForge/theme.css
Outdated
// SPDX-FileCopyrightText: yar2000T <https://github.com/yar2000T> | ||
// SPDX-License-Identifier: CC-BY-4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think //
is not a valid comment in CSS. And the CC-BY obliges you to name the original author. So this would be correct in this case:
// SPDX-FileCopyrightText: yar2000T <https://github.com/yar2000T> | |
// SPDX-License-Identifier: CC-BY-4.0 | |
/* SPDX-FileCopyrightText: yar2000T <https://github.com/yar2000T> */ | |
/* SPDX-FileCopyrightText: Simon Schneegans <[email protected]> */ | |
/* SPDX-License-Identifier: CC-BY-4.0 */ |
Added KnightForge theme