Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patched fido-mds to fix 'unknown variant wireless' error #474

Closed
wants to merge 1 commit into from

Conversation

assimilat
Copy link

This patch was just made to suppress the following error. I dont know if it has any serious implications, but it worked for me.:

serde_err=Error("unknown variant `wireless`, expected one of `usb`, `nfc`, `lightning`, `ble`, `internal`", line: 1, column: 14303)

When running:

./fido-mds-tool query --output-cert-roots "desc cnt yubikey"
./fido-mds-tool list-u2f
./fido-mds-tool list-fido2

On a freshly updated Arch Linux, and compiled using both 'stable-x86_64-unknown-linux-gnu' 'nightly-2025-02-16-x86_64-unknown-linux-gnu' toolchains from rust-up.

Error was encountered while following this guide.

  • [?] cargo test has been run and passes

I received the following errors running "cargo test". I don't think that they are related to my patch, but I could be wrong.

2025-02-17T07:42:17.221766Z ERROR sshkey_attest: ed25519 or ed448 public keys are not supported
2025-02-17T07:42:17.221922Z ERROR sshkey_attest: aaguid not trusted by this CA aaguid=cb69481e-8ff7-4039-93ec-0a2729a154a8
2025-02-17T07:42:17.227172Z ERROR webauthn_authenticator_rs::nfc: could not convert "\xff\xff" to UTF-8: Utf8Error { valid_up_to: 0, error_len: Some(1) }
2025-02-17T07:42:17.227207Z ERROR webauthn_authenticator_rs::nfc: could not convert "\xffYubico YubiKey FIDO+CCID\xff" to UTF-8: Utf8Error { valid_up_to: 0, error_len: Some(1) }
2025-02-17T07:42:24.335063Z ERROR webauthn_rs_core::core: Authenticator ignored requested algorithm set - ES256 - [RS256, EDDSA, INSECURE_RS1]

@yaleman
Copy link
Member

yaleman commented Feb 19, 2025

I believe this was already fixed in #473 ? You will need to rebase your PR either way please.

@Firstyear
Copy link
Member

Yep already fixed.

@assimilat
Copy link
Author

right on. sorry for the trouble.

@assimilat assimilat closed this Feb 20, 2025
@Firstyear
Copy link
Member

Not your fault at all, the fault is with FIDO for breaking their MDS without updating the specification of it, nor giving any kind of notice to implementors they are making the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants