Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid json in librelingo_yaml_loader #3175

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Fix invalid json in librelingo_yaml_loader #3175

merged 1 commit into from
Dec 27, 2023

Conversation

sublime-coleslaw
Copy link
Contributor

scripts/verifyTestCourseJsonFiles.sh breaks on invalid json

@sublime-coleslaw
Fix invalid json in librelingo_yaml_loader
2a6b80d 
scripts/verifyTestCourseJsonFiles.sh breaks on invalid json
@kantord
Copy link
Owner

kantord commented Nov 22, 2023

wow, so this means that this script is not being run in the CI 😮 I think that this script is meant to be executed in the CI to make sure that breaking changes cannot be accidentally merged

@sublime-coleslaw
Copy link
Contributor Author

the deployment and python workflows run the verifyTestCourseJsonFiles script, but a different issue (#3176) has been breaking CI before the verifyTestCourseJsonFiles script even runs, so I think that's why this comma wasn't caught. #3177 adds a json linter in pre-commit

@kantord kantord merged commit 5b22da0 into kantord:main Dec 27, 2023
4 checks passed
@kantord
Copy link
Owner

kantord commented Dec 27, 2023

thanks @sublime-coleslaw !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sublime-coleslaw @kantord