Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: area displays size on inspect #38

Merged
merged 2 commits into from
May 24, 2024
Merged

fix: area displays size on inspect #38

merged 2 commits into from
May 24, 2024

Conversation

amyspark-ng
Copy link
Contributor

area apparently used to display "area" when inspecting, now it displays the vector size, in the same format as pos

@mflerackers
Copy link
Member

Most likely you'll need to add inspect methods to each shape class. Then you can add shape: ${shape.inspect()}

@amyspark-ng
Copy link
Contributor Author

that'd be nice, i could add that too

@amyspark-ng
Copy link
Contributor Author

think i won't since it looks like the debug.inspect system is getting remade into something much nicer, feels like adding shape might imply also adding things like offset maybe? and also bloat the little box you get when you hover something on inspect mode, so i don't think i will

@niceEli niceEli merged commit d8e5187 into kaplayjs:master May 24, 2024
1 check passed
@amyspark-ng amyspark-ng deleted the amy-display-area-on-inspect branch May 24, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants