Fix moment.js deprecation warning #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -80,3 +80,5 @@ yarn-debug.log* | |||
| yarn-error.log* | |||
| .vscode/launch.json | |||
| package-lock.json | |||
|
|
|||
| .idea/ | |||
There was a problem hiding this comment.
sure it can't hurt!
what is this for, out of curiosity :)
There was a problem hiding this comment.
If you are using IDE from JetBrains (I use WebStorm for web stack) - the IDE put own files into .idea path. It is unnecessary put those files into repository. This row hide path and subfiles for GIT version control system
karismatic-megafauna
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #41
The problem: your data format
MM/DD/YYYYis not ISO format. I changed working format to ISO-date formatYYYY-DD-MM, and convert it only in Sidebar displayAlso this change fix the problem of absent leading zeros in days and months with 1-digit