Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node.js v22 #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade to Node.js v22 #1

wants to merge 1 commit into from

Conversation

karlhorky
Copy link
Owner

It looks like the Node.js v22 PR contains the fix "module,win: fix long path resolve (by @StefanStojanovic) nodejs/node#51097":

So maybe Node.js has support for long paths on Windows now!

@karlhorky
Copy link
Owner Author

Hm, the test run of the GitHub Actions workflow still failed:

Run (Get-ItemProperty "HKLM:System\CurrentControlSet\Control\FileSystem").LongPathsEnabled
1

Run actions/setup-node@v4
Attempting to download >=22.1.0...
Not found in manifest. Falling back to download directly from Node
Acquiring 22.1.0 - x64 from https://nodejs.org/dist/v22.1.0/node-v22.1.0-win-x64.7z
Extracting ...
Adding to the cache ...
Done
Environment details
  node: v22.1.0
  npm: 10.7.0
  yarn: 1.22.22

$ node eslint.config.js
node:internal/modules/run_main:125
    triggerUncaughtException(
    ^

Error: Cannot find package 'D:\a\node-js-max_path-windows-bug\node-js-max_path-windows-bug\long-path\long-path\long-path\long-path\long-path\long-path\long-path\long-path\long-path\long-path\long-path\long-path\long-path\long-path\long-path\long-path\long-path\node_modules\eslint-plugin-import\package.json' imported from D:\a\node-js-max_path-windows-bug\node-js-max_path-windows-bug\long-path\long-path\long-path\long-path\long-path\long-path\long-path\long-path\long-path\long-path\long-path\long-path\long-path\long-path\long-path\long-path\long-path\eslint.config.js
Did you mean to import "eslint-plugin-import/lib/index.js"?
    at legacyMainResolve (node:internal/modules/esm/resolve:214:26)
    at packageResolve (node:internal/modules/esm/resolve:832:14)
    at moduleResolve (node:internal/modules/esm/resolve:918:18)
    at defaultResolve (node:internal/modules/esm/resolve:1148:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:541:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:510:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:240:38)
    at ModuleJob._link (node:internal/modules/esm/module_job:126:49) {
  code: 'ERR_MODULE_NOT_FOUND'
}

Node.js v22.1.0
Error: Process completed with exit code 1.

Here's the file it's running (this file runs fine in a location in a shorter path):

eslint.config.js

import eslintImport from 'eslint-plugin-import';

const config = [
  {
    plugins: {
      import: eslintImport,
    },
    rules: {
      'no-unused-vars': 'warn',
    },
  },
];

export default config;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant