feat : add cluster registration step in pull mode to installation-cli.yaml #6006
Conversation
karmada-bot
added
do-not-merge/contains-merge-commits
SkySingh04
changed the title
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6006 +/- ##
==========================================
- Coverage 48.12% 48.10% -0.02%
==========================================
Files 668 668
Lines 55291 55313 +22
==========================================
+ Hits 26609 26610 +1
- Misses 26948 26968 +20
- Partials 1734 1735 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SkySingh04
force-pushed
the
karmadactlInstallationCLI
branch
from
e94498a to
5d8cefa
Compare
karmada-bot
removed
the
do-not-merge/contains-merge-commits
|
/assign |
|
@SkySingh04 the ci failed due to not finding the command karmadactl register cluster \
--cluster-name ${{ matrix.k8s }} \
--mode Pull |
karmada-bot
added
size/S
karmada-bot
added
size/L
|
@zhzhuang-zju This PR is also related to the issue we are facing in #6007 as well. Reference : |
|
@SkySingh04 The CI has two jobs, For example, the job karmada/hack/cli-testing-environment.sh Lines 115 to 118 in 3d25407 |
SkySingh04
force-pushed
the
karmadactlInstallationCLI
branch
from
48d2fc9 to
f223397
Compare
Signed-off-by: zhzhuang-zju <[email protected]>
Signed-off-by: zhzhuang-zju <[email protected]>
Signed-off-by: zhzhuang-zju <[email protected]>
Signed-off-by: zhzhuang-zju <[email protected]>
Signed-off-by: zhzhuang-zju <[email protected]>
Signed-off-by: zhzhuang-zju <[email protected]>
SkySingh04
force-pushed
the
karmadactlInstallationCLI
branch
3 times, most recently
from
7c448f8 to
e4cc1e8
Compare
|
@zhzhuang-zju Your requested changes have been made, branch rebased and commits squashed! |
SkySingh04
force-pushed
the
karmadactlInstallationCLI
branch
2 times, most recently
from
c663e94 to
55803b5
Compare
|
@zhzhuang-zju Your requested changes have been made and the CI is passing! |
| @@ -99,6 +99,7 @@ kind load docker-image "${REGISTRY}/karmada-controller-manager:${VERSION}" --nam | |||
| kind load docker-image "${REGISTRY}/karmada-scheduler:${VERSION}" --name="${HOST_CLUSTER_NAME}" | |||
| kind load docker-image "${REGISTRY}/karmada-webhook:${VERSION}" --name="${HOST_CLUSTER_NAME}" | |||
| kind load docker-image "${REGISTRY}/karmada-aggregated-apiserver:${VERSION}" --name="${HOST_CLUSTER_NAME}" | |||
| kind load docker-image "${REGISTRY}/karmada-agent:${VERSION}" --name="${MEMBER_CLUSTER_1_NAME}" | |||
There was a problem hiding this comment.
This step also needs to be synchronized into hack/cli-testing-init-with-config.sh to ensure that the CI uses the image generated from the latest code instead of the image pulled from the remote image repository.
SkySingh04
force-pushed
the
karmadactlInstallationCLI
branch
from
55803b5 to
fc37762
Compare
|
@zhzhuang-zju updated! |
|
/lgtm |
| @@ -44,6 +44,8 @@ jobs: | |||
| hack/cli-testing-environment.sh | |||
| # run a single e2e | |||
| export PULL_BASED_CLUSTERS="member1:${HOME}/.kube/member1.config" | |||
| export KARMADA_PULL_CLUSTER_NAME="member1" | |||
There was a problem hiding this comment.
This variable does not seem to be necessary. Can you help confirm it?
There was a problem hiding this comment.
you mean KARMADA_PULL_CLUSTER_NAME?
There was a problem hiding this comment.
@XiShanYongYe-Chang If the e2e test needs to identify cluster member1 as a pull-mode cluster, we need to export these variables :
CC : #6006 (comment)
There was a problem hiding this comment.
you mean KARMADA_PULL_CLUSTER_NAME?
Yes, it is.
There was a problem hiding this comment.
@XiShanYongYe-Chang Apologies for my oversight, this export is not needed and is removed
| @@ -44,6 +44,8 @@ jobs: | |||
| hack/cli-testing-environment.sh | |||
| # run a single e2e | |||
| export PULL_BASED_CLUSTERS="member1:${HOME}/.kube/member1.config" | |||
There was a problem hiding this comment.
Setting member1 as a pull cluster is the logic of the hack/cli-testing-environment.sh script, so I suggest setting this variable in the script as well.
There was a problem hiding this comment.
@XiShanYongYe-Chang If we set the var in the script, the CI fails to run
Job Runs : https://github.com/karmada-io/karmada/actions/runs/13429989962/job/37519737449?pr=6006 and https://github.com/karmada-io/karmada/actions/runs/13429989962/job/37519739035?pr=6006
There was a problem hiding this comment.
Is it because the variables set in the script fail outside the script?
There was a problem hiding this comment.
yes, since they are needed for the e2e tests
ginkgo -v --race --trace -p --focus="[BasicPropagation] propagation testing deployment propagation testing" ./test/e2e/suites/base
CC : @zhzhuang-zju can confirm
There was a problem hiding this comment.
Sorry for commenting on a wrong direction.
There was a problem hiding this comment.
no worries! I have removed the commit and we are good to go!
SkySingh04
force-pushed
the
karmadactlInstallationCLI
branch
from
d3e82b9 to
fc37762
Compare
|
@XiShanYongYe-Chang If all comments are resolved, we are good to go! |
Signed-off-by: Sky Singh <[email protected]>
SkySingh04
force-pushed
the
karmadactlInstallationCLI
branch
from
5149870 to
1120b10
Compare
|
@XiShanYongYe-Chang @zhzhuang-zju Following up on this, Any blockers for this to be merged? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
|
thanks, |
|
/lgtm |
Signed-off-by: Akash [email protected]
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Parts of #5916
Special notes for your reviewer:
Does this PR introduce a user-facing change?: