add comment for image pull secret

kartverket · Aug 13, 2024 · 644c3be · 644c3be
1 parent 1dc9b13
commit 644c3be
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/pkg/resourcegenerator/github/image_pull_secret.go b/pkg/resourcegenerator/github/image_pull_secret.go
@@ -35,6 +35,8 @@ func (ips *imagePullSecret) Generate(r reconciliation.Reconciliation) error {
 	if r.GetType() != reconciliation.NamespaceType {
 		return fmt.Errorf("image pull secret only supports namespace type")
 	}
+	// SKIPObject here is a namespace, so thats why we use GetName, not GetNamespace.
+	// Should NOT be called from any other controller than namespace-controller
 	secret := corev1.Secret{ObjectMeta: metav1.ObjectMeta{Namespace: r.GetSKIPObject().GetName(), Name: "github-auth"}}
 	secret.Type = corev1.SecretTypeDockerConfigJson