Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use List::Util instead of List::MoreUtils #171

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

plicease
Copy link
Contributor

Suggestion: use List::Util for any, all and unique, and replace zip with mesh instead of List::MoreUtils. The former comes bundled with Perl so it is fewer dependencies for a modern version of Perl, and as of 1.56 all of those functions are available in List::Util. mesh from List::Util works similar to zip from List::MoreUtils, except it doesn't rely on prototypes, so you pass array references instead. I also found a couple of places where the functions were imported but not used.

@kjetilk
Copy link
Contributor

kjetilk commented Jan 13, 2025

Just one question: They are written with XS in List::Util too?

@plicease
Copy link
Contributor Author

Just one question: They are written with XS in List::Util too?

Yes, in. fact they are more likely to be implemented using XS since List::MoreUtils have a pure perl implementation which is used when there isn't a compiler available. Since List::Util.

@kasei kasei merged commit d5503e4 into kasei:master Jan 14, 2025
3 of 12 checks passed
@kasei
Copy link
Owner

kasei commented Jan 14, 2025

Thanks!

@plicease
Copy link
Contributor Author

Just one question: They are written with XS in List::Util too?

Yes, in. fact they are more likely to be implemented using XS since List::MoreUtils have a pure perl implementation which is used when there isn't a compiler available. Since List::Util.

Just realized that I left that last sentence incomplete lol, for posterity should read "Since List::Util is built with Perl when there is always a compiler available it will always be XS."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants