-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iri2pref #63
Iri2pref #63
Conversation
|
||
} else { | ||
|
||
return $html; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this have an HTML link, too, with $html
as both the href and the link text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem! Looks like I will have to modify the t/serializer-sparqlhtml.t too since some tests expect the plain IRIs. Or perhaps you want this change only when there is URI::NamespaceMap instance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like it done whether or not there's a namespace map.
I was planning on merging your test file with t/serializer-sparqlhtml.t anyway. So if you don't want to do that, I can take care of it during the merge.
Hi Zoran. This looks like a great PRC patch. I added one comment asking for a small change. Other than that, this looks good to merge. Thanks! |
Hi Greg, |
Hi Greg,
This is my first attempt to address the #54 issue as part of the CPAN PRC :-)
Looking forward to your feedback!
Thanks,
Zoran