feat: add source trait #2275
Triggered via pull request
October 11, 2023 02:04
jordanrfrazier
synchronize
#803
Status
Success
Total duration
17s
Artifacts
–
Annotations
1 error
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true:
crates/sparrow-batch/src/row_time.rs#L37
error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> crates/sparrow-batch/src/row_time.rs:37:1
|
37 | impl Into<RowTime> for i64 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `-D clippy::from-over-into` implied by `-D warnings`
help: replace the `Into` implementation with `From<i64>`
|
37 ~ impl From<i64> for RowTime {
38 ~ fn from(val: i64) -> Self {
39 ~ RowTime(val)
|
|