Skip to content

feat: partitioned merge pipeline #2367

feat: partitioned merge pipeline

feat: partitioned merge pipeline #2367

Triggered via pull request October 24, 2023 07:05
@jordanrfrazierjordanrfrazier
synchronize #828
Status Success
Total duration 14s
Artifacts

pr_labeler.yml

on: pull_request_target
Fit to window
Zoom out
Zoom in

Annotations

8 errors
this lifetime isn't used in the function definition: crates/sparrow-merge/src/merge_pipeline.rs#L102
error: this lifetime isn't used in the function definition --> crates/sparrow-merge/src/merge_pipeline.rs:102:20 | 102 | pub fn try_new<'a>( | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes = note: `-D clippy::extra-unused-lifetimes` implied by `-D warnings`
methods `spread_signaled`, `spread_true`, and `spread_false` are never used: crates/sparrow-merge/src/spread.rs#L135
error: methods `spread_signaled`, `spread_true`, and `spread_false` are never used --> crates/sparrow-merge/src/spread.rs:135:12 | 94 | impl Spread { | ----------- methods in this implementation ... 135 | pub fn spread_signaled( | ^^^^^^^^^^^^^^^ ... 145 | pub fn spread_true( | ^^^^^^^^^^^ ... 154 | pub fn spread_false( | ^^^^^^^^^^^^
fields `input_l`, `input_r`, and `result_type` are never read: crates/sparrow-merge/src/merge_pipeline.rs#L24
error: fields `input_l`, `input_r`, and `result_type` are never read --> crates/sparrow-merge/src/merge_pipeline.rs:24:5 | 18 | pub struct MergePipeline { | ------------- fields in this struct ... 24 | input_l: StepId, | ^^^^^^^ 25 | /// The id for the right input 26 | input_r: StepId, | ^^^^^^^ ... 35 | result_type: DataType, | ^^^^^^^^^^^ | = note: `-D dead-code` implied by `-D warnings`
unused variable: `gathered_batches`: crates/sparrow-merge/src/merge_pipeline.rs#L306
error: unused variable: `gathered_batches` --> crates/sparrow-merge/src/merge_pipeline.rs:306:21 | 306 | let gathered_batches = gatherer.next_batch(); | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_gathered_batches`
unused variable: `right`: crates/sparrow-merge/src/merge_pipeline.rs#L283
error: unused variable: `right` --> crates/sparrow-merge/src/merge_pipeline.rs:283:21 | 283 | let right: &Batch = &concatted_batches[1]; | ^^^^^ help: if this is intentional, prefix it with an underscore: `_right`
unused variable: `left`: crates/sparrow-merge/src/merge_pipeline.rs#L282
error: unused variable: `left` --> crates/sparrow-merge/src/merge_pipeline.rs:282:21 | 282 | let left: &Batch = &concatted_batches[0]; | ^^^^ help: if this is intentional, prefix it with an underscore: `_left` | = note: `-D unused-variables` implied by `-D warnings`
unused import: `itertools::Itertools`: crates/sparrow-merge/src/merge_pipeline.rs#L6
error: unused import: `itertools::Itertools` --> crates/sparrow-merge/src/merge_pipeline.rs:6:5 | 6 | use itertools::Itertools; | ^^^^^^^^^^^^^^^^^^^^
unused import: `spread::*`: crates/sparrow-merge/src/lib.rs#L18
error: unused import: `spread::*` --> crates/sparrow-merge/src/lib.rs:18:16 | 18 | pub(crate) use spread::*; | ^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings`