Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add get function for maps (for string -> primitive) #500

Merged
merged 20 commits into from
Jul 18, 2023
Merged

feat: add get function for maps (for string -> primitive) #500

merged 20 commits into from
Jul 18, 2023

Conversation

jordanrfrazier
Copy link
Collaborator

@jordanrfrazier jordanrfrazier commented Jul 12, 2023 •
edited
Loading

Adds the get function for maps for string and large_string to primitive types.

Further additions can support more types. See #494 for task list

Testing:

  • verified that the sample map data (with a largeutf8) produces results as expected.

@cla-bot cla-bot bot added the cla-signed Set when all authors of a PR have signed our CLA label Jul 12, 2023
@github-actions github-actions bot added enhancement New feature or request sparrow labels Jul 12, 2023
@github-actions github-actions bot added the proto label Jul 13, 2023
@jordanrfrazier jordanrfrazier marked this pull request as ready for review July 13, 2023 19:06
bjchambers
bjchambers reviewed Jul 13, 2023
View reviewed changes
crates/sparrow-api/src/kaskada/v1alpha/plan_impl.rs Outdated Show resolved Hide resolved
crates/sparrow-arrow/src/scalar_value.rs Show resolved Hide resolved
crates/sparrow-compiler/src/ast_to_dfg.rs Show resolved Hide resolved
crates/sparrow-compiler/src/dfg.rs Show resolved Hide resolved
crates/sparrow-compiler/src/types/inference.rs Outdated Show resolved Hide resolved
crates/sparrow-instructions/src/evaluators/macros.rs Outdated Show resolved Hide resolved
crates/sparrow-instructions/src/evaluators/map/get_large_string_to_primitive.rs Outdated Show resolved Hide resolved
crates/sparrow-main/tests/e2e/basic_error_tests.rs Outdated Show resolved Hide resolved
crates/sparrow-main/tests/e2e/fixtures.rs Outdated Show resolved Hide resolved
crates/sparrow-runtime/src/read/parquet_stream.rs Outdated Show resolved Hide resolved
@jordanrfrazier jordanrfrazier added this pull request to the merge queue Jul 18, 2023
Merged via the queue into main with commit c700afe Jul 18, 2023
32 checks passed
@jordanrfrazier jordanrfrazier deleted the get-key-from-map-function branch July 18, 2023 01:41
@jordanrfrazier jordanrfrazier mentioned this pull request Jul 18, 2023
Open
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjchambers bjchambers bjchambers approved these changes

@therapon therapon Awaiting requested review from therapon

Assignees
No one assigned
Labels
cla-signed Set when all authors of a PR have signed our CLA enhancement New feature or request proto sparrow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordanrfrazier @bjchambers