-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
beta release flow using separate files #508
Conversation
This fixes warnings appearing in the new version of Rust.
# leave the latest workflow and cancel the other (older) workflows | ||
# See https://docs.github.com/en/actions/using-jobs/using-concurrency | ||
concurrency: | ||
group: engine-release-beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to tell what is actually different here. Shouldn't the beta release be the same as the regular release, just with a different label?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost. A couple of issues
- Release takes over an already open draft. I did not want to alter that flow. If I use the release-drafter for Beta it takes over the draft. I would have to create 2 drafts one for beta and one for release
- Most changes are in the publishing of the binaries.
- Beta marks GitHub releases as pre-release and does not mark anything as latest.
- Docker images for beta do not get a
latest
tag. - No binaries are send anywhere (e.g. PyPy) other than the beta release on GitHub
- Github release for beta use
gh
to create and add notes from included PRs.
I would like to make it part of one file and reuse as much as possible. If this workflow works (I need to commit once and then try it out) I am planning to unify the files. (see comment in the PR)
…da into tsk-beta-separate-files
Closing this in favour of a new PR |
if
flows in one file again. I tried it locally and it got hairyWanted to commit this and try the flow before adding docs on the process.