beta release flow using separate files #508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes warnings appearing in the new version of Rust.
cla-bot
bot
added
the
cla-signed
bjchambers
reviewed
Jul 13, 2023
| # leave the latest workflow and cancel the other (older) workflows | ||
| # See https://docs.github.com/en/actions/using-jobs/using-concurrency | ||
| concurrency: | ||
| group: engine-release-beta |
There was a problem hiding this comment.
It's hard to tell what is actually different here. Shouldn't the beta release be the same as the regular release, just with a different label?
There was a problem hiding this comment.
Almost. A couple of issues
- Release takes over an already open draft. I did not want to alter that flow. If I use the release-drafter for Beta it takes over the draft. I would have to create 2 drafts one for beta and one for release
- Most changes are in the publishing of the binaries.
- Beta marks GitHub releases as pre-release and does not mark anything as latest.
- Docker images for beta do not get a
latesttag. - No binaries are send anywhere (e.g. PyPy) other than the beta release on GitHub
- Github release for beta use
ghto create and add notes from included PRs.
I would like to make it part of one file and reuse as much as possible. If this workflow works (I need to commit once and then try it out) I am planning to unify the files. (see comment in the PR)
…da into tsk-beta-separate-files
|
Closing this in favour of a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ifflows in one file again. I tried it locally and it got hairyWanted to commit this and try the flow before adding docs on the process.