feat: udf node creation in dfg #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
jordanrfrazier
commented
Aug 19, 2023
bjchambers
reviewed
Aug 21, 2023
bjchambers
reviewed
Aug 21, 2023
bjchambers
approved these changes
Aug 21, 2023
jordanrfrazier
force-pushed
the
python-udf/sparrow-trait-plumbing-
branch
from
2bd37c6
to
4d659b8
Compare
bjchambers
reviewed
Aug 22, 2023
jordanrfrazier
force-pushed
the
python-udf/sparrow-trait-plumbing-
branch
from
a3a9e90
to
b946b67
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little bit more plumbing for UDFs. Adds ability for
python.Exprto call into thesparrow-session::Session::add_udf_to_dfgmethod, which adds the udf directly to the dfg.