bug: drains output channel when batching results #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
jordanrfrazier
commented
Sep 20, 2023
jordanrfrazier
commented
Sep 20, 2023
|
Current status with runtime in session and using handles: the runtime is closing unexpectedly when a query is being made, resulting in an error. Need to investigate deeper into why this is happening. |
bjchambers
requested changes
Sep 25, 2023
jordanrfrazier
force-pushed
the
bug-testing-output-channel-blocks
branch
from
ea5c2aa
to
703aaf7
Compare
bjchambers
reviewed
Sep 25, 2023
1. Creating (and dropping) a tokio runtime in `session` lead to problems 2. The logic in the `select` led to problems (progress always reported `None` once the stream was done, and being biased chose that). This is fixed by preferring `futures::select!` and `select_next_some`.
jordanrfrazier
force-pushed
the
bug-testing-output-channel-blocks
branch
from
ec2310e
to
73b93c9
Compare
bjchambers
approved these changes
Sep 27, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drains the output channel. Previously was causing queries to block on send.
Puts the tokio runtime into an
Arcto share it -- thehandle()was not working like I wanted since it was being dropped (a blocking method) from an asynchronous context. Unsure why, but swapping to useArc, as is also recommended, works fine.https://docs.rs/tokio/latest/tokio/runtime/struct.Runtime.html#sharing
Closes #775