-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: move prepared files to ~/.cache dir #781
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
Set when all authors of a PR have signed our CLA
label
Sep 28, 2023
Until we start re-using them, we really should delete them. Otherwise, every run of the test creates files that build up over time, eventually leading to out of disk space. And now it's in a hidden cache directory. I think:
|
jordanrfrazier
commented
Sep 28, 2023
jordanrfrazier
force-pushed
the
move-prepared-data-directory
branch
from
October 3, 2023 15:54
128f626
to
5a2542f
Compare
bjchambers
reviewed
Oct 3, 2023
jordanrfrazier
force-pushed
the
move-prepared-data-directory
branch
from
October 3, 2023 20:31
7f18518
to
c3cb4d7
Compare
bjchambers
reviewed
Oct 4, 2023
bjchambers
reviewed
Oct 5, 2023
bjchambers
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the prepared files directory to
~/.cache/kaskada/
.The other alternative is to, for now, create a temporary directory that cleans up after use. While the
~/.cache
is generally used for application-specific files (which is what the prepared files are), we aren't utilizing them and won't until we have state. But, if it's not a large concern to accumulate prepared files in the cache, we might as well start with it here in anticipation of using them.Closes #779